Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slug function #3876

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix slug function #3876

merged 1 commit into from
Nov 16, 2017

Conversation

mistercrunch
Copy link
Member

Previous slug function would strip - characters.

fixes #3803

xrmx
xrmx reviewed Nov 15, 2017
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django does this after normalizing to ascii:

    value = re.sub(r'[^\w\s-]', '', value).strip().lower()
    return re.sub(r'[-\s]+', '-', value)

@fabianmenges
Copy link
Contributor

What about international 'slugs'?

@mistercrunch
Copy link
Member Author

Yeah I researched this a bit and refrained from adding a dependency that does this.

@mistercrunch mistercrunch merged commit d9161fb into apache:master Nov 16, 2017
@mistercrunch mistercrunch deleted the fix_slug branch November 16, 2017 17:47
@michellethomas michellethomas mentioned this pull request Nov 29, 2017
Merged
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Fix slug function (apache#3876)
3ba24d2
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Fix slug function (apache#3876)
123a60d
@matrix-compute matrix-compute mentioned this pull request Dec 15, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Dec 16, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jan 30, 2024
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
@matrix-compute matrix-compute mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx left review comments

@fabianmenges fabianmenges fabianmenges approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard][Slug] Spaces and hyphens are being ignored.
3 participants
@mistercrunch @fabianmenges @xrmx